Eliminate spurious and duplicate DHWSYS energy balance errors #538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nealkruis
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modest DHWSYS energy balance errors are common at short time intervals and during PRERUN (when the DHWSYS is often undersized).
In addition, runs that have a single DHWSYS contain a "sum_of" DHWSYSRES record that is identical to its source. It is not necessary to do an energy balance check on both.
The changes in this PR refines the logic of when DHWSYS energy balance checks are done and the tolerances used.
This eliminated all messages in a large multifamily case supplied by a user.
No documentation changes.
No test result changes.